Revised native conda locator #23416
Merged
Revised native conda locator #23416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
May 13, 2024
native_locator/src/conda_new.rs
Outdated
| for possible_conda_folder in get_known_conda_install_locations(environment) { | ||
| if possible_conda_folder.exists() { | ||
| if let Some(manager) = get_conda_manager(&possible_conda_folder) { | ||
| let envs = get_conda_environments_from_conda_directory( |
There was a problem hiding this comment.
These two are the key functions get_conda_manager and get_conda_environmetns_from_conda_directory
Given any conda installation, we can find all conda exes and all envs.
Thus we can easily support anaconda, miniconda, miniforge, even conda installs where the directory is found from the windows registry...
DonJayamanne
added
no-changelog
anthonykim1
pushed a commit
to anthonykim1/vscode-python
that referenced
this pull request
May 16, 2024
**Fixes** * microsoft#23413 * & the fact that we always use the same conda exe to manage all conda envs, even if multiple are installed. * Step 1: * Look for conda install folders in known locations such as `/<user home>/miniconda3`, `<user profile>/Anaconda3` * Step 2: * For each install location identified, inspect that folder and extract the * Conda executable * All environments belonging to that conda installation * Step 3: * Old approach, * 1. find any conda in sys path or other locations and find conda installation via that mechanism * 2. Get all envs from environments.txt file (any remaining conda envs not discovered in 1 & 2 will be discoverred here and use some the global conda exe) Once we have step 1 and 2, I do not expect anything new to show up in step 3, Even if users install conda into some custom locations (the solution would be to run step 1 with the custom location provided by user in settings.json file) **How to find environments?** * Look in the `envs` folder of the conda installation * Look at the entries in the `environments.txt` file * Look at the `env_dirs` in the `.condarc` file With these two, we should be able to eliminate the need to ever spawn conda to get the env directories. **How do we know whether a conda environment belongs to a specific conda installation** * If it is in the `envs` sub directory of the conda installation * Else, have a look at `<env folder>/conda-meta/history` file to look at the conda installation that was used to create this environment
DonJayamanne
added a commit
that referenced
this pull request
Jun 24, 2024
**Fixes** * #23413 * & the fact that we always use the same conda exe to manage all conda envs, even if multiple are installed. * Step 1: * Look for conda install folders in known locations such as `/<user home>/miniconda3`, `<user profile>/Anaconda3` * Step 2: * For each install location identified, inspect that folder and extract the * Conda executable * All environments belonging to that conda installation * Step 3: * Old approach, * 1. find any conda in sys path or other locations and find conda installation via that mechanism * 2. Get all envs from environments.txt file (any remaining conda envs not discovered in 1 & 2 will be discoverred here and use some the global conda exe) Once we have step 1 and 2, I do not expect anything new to show up in step 3, Even if users install conda into some custom locations (the solution would be to run step 1 with the custom location provided by user in settings.json file) **How to find environments?** * Look in the `envs` folder of the conda installation * Look at the entries in the `environments.txt` file * Look at the `env_dirs` in the `.condarc` file With these two, we should be able to eliminate the need to ever spawn conda to get the env directories. **How do we know whether a conda environment belongs to a specific conda installation** * If it is in the `envs` sub directory of the conda installation * Else, have a look at `<env folder>/conda-meta/history` file to look at the conda installation that was used to create this environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Avoid spawning Conda to get list of environments and conda version #23413
& the fact that we always use the same conda exe to manage all conda envs, even if multiple are installed.
Step 1:
/<user home>/miniconda3,<user profile>/Anaconda3Step 2:
Step 3:
Once we have step 1 and 2, I do not expect anything new to show up in step 3,
Even if users install conda into some custom locations (the solution would be to run step 1 with the custom location provided by user in settings.json file)
How to find environments?
envsfolder of the conda installationenvironments.txtfileenv_dirsin the.condarcfileWith these two, we should be able to eliminate the need to ever spawn conda to get the env directories.
How do we know whether a conda environment belongs to a specific conda installation
envssub directory of the conda installation<env folder>/conda-meta/historyfile to look at the conda installation that was used to create this environment